Merge pull request fluidattacks#1384 from rohaquinlop/issue-1374

feat(build): fluidattacks#1374 deprecate lint-markdown
rohaquinlop · Oct 22, 2024 · 382fe21 · 382fe21
2 parents 1cde20d + a0da1f9
commit 382fe21
Show file tree

Hide file tree

Showing 13 changed files with 0 additions and 187 deletions.
diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
@@ -264,22 +264,6 @@ jobs:
       - name: /lintGitMailMap
         run: nix-env -if . && m . /lintGitMailMap
 
-  linux_lintMarkdown_all:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@f095bcc56b7c2baf48f3ac70d6d6782f4f553222
-      - uses: docker://docker.io/nixos/nix@sha256:c3db4c484f6b1ee6c9bb8ca90307cfbeca8ef88156840911356a677eeaff4845
-        name: /lintMarkdown/all
-        with:
-          args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /lintMarkdown/all"
-  macos_lintMarkdown_all:
-    runs-on: macos-latest
-    steps:
-      - uses: actions/checkout@f095bcc56b7c2baf48f3ac70d6d6782f4f553222
-      - uses: cachix/install-nix-action@6ed004b9ccb68dbc28e7c85bee15fa93dbd214ac
-      - name: /lintMarkdown/all
-        run: nix-env -if . && m . /lintMarkdown/all
-
   linux_lintNix:
     runs-on: ubuntu-latest
     steps:

diff --git a/.github/workflows/prod.yml b/.github/workflows/prod.yml
@@ -402,26 +402,6 @@ jobs:
         env:
           CACHIX_AUTH_TOKEN: ${{ secrets.CACHIX_AUTH_TOKEN }}
 
-  linux_lintMarkdown_all:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@f095bcc56b7c2baf48f3ac70d6d6782f4f553222
-      - uses: docker://docker.io/nixos/nix@sha256:c3db4c484f6b1ee6c9bb8ca90307cfbeca8ef88156840911356a677eeaff4845
-        name: /lintMarkdown/all
-        with:
-          args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /lintMarkdown/all"
-        env:
-          CACHIX_AUTH_TOKEN: ${{ secrets.CACHIX_AUTH_TOKEN }}
-  macos_lintMarkdown_all:
-    runs-on: macos-latest
-    steps:
-      - uses: actions/checkout@f095bcc56b7c2baf48f3ac70d6d6782f4f553222
-      - uses: cachix/install-nix-action@6ed004b9ccb68dbc28e7c85bee15fa93dbd214ac
-      - name: /lintMarkdown/all
-        run: nix-env -if . && m . /lintMarkdown/all
-        env:
-          CACHIX_AUTH_TOKEN: ${{ secrets.CACHIX_AUTH_TOKEN }}
-
   linux_lintNix:
     runs-on: ubuntu-latest
     steps:

diff --git a/docs/src/api/builtins/lint.md b/docs/src/api/builtins/lint.md
@@ -154,52 +154,6 @@ Example:
     m . /lintGitMailMap
     ```
 
-## lintMarkdown
-
-Lints Markdown code with [Markdown lint tool](https://github.com/markdownlint/markdownlint).
-
-Types:
-
-- lintMarkdown (`attrsOf moduleType`): Optional.
-    Definitions of config and associated paths to lint.
-    Defaults to `{ }`.
-- moduleType (`submodule`):
-    - config (`str`): Optional.
-        Path to the config file.
-        Defaults to [config.rb](https://github.com/fluidattacks/makes/blob/main/src/evaluator/modules/lint-markdown/config.rb).
-    - targets (`listOf str`): Required.
-        paths to lint with `config`.
-    - rulesets (`str`): Optional.
-        Path to the custom rulesets file.
-        Defaults to [rulesets.rb](https://github.com/fluidattacks/makes/blob/main/src/evaluator/modules/lint-markdown/rulesets.rb).
-
-Example:
-
-=== "makes.nix"
-
-    ```nix
-    {
-      lintMarkdown = {
-        all = {
-          # You can pass custom configs like this:
-          # config = "/src/config/markdown.rb";
-          # You can pass custom rules like this:
-          # rulesets = "/src/config/rulesets.rb";
-          targets = [ "/" ];
-        };
-        others = {
-          targets = [ "/others" ];
-        };
-      };
-    }
-    ```
-
-=== "Invocation"
-
-    ```bash
-      m . /lintMarkdown/all
-    ```
-
 ## lintNix
 
 Lints Nix code with [statix](https://github.com/nerdypepper/statix).

diff --git a/docs/src/contributing.md b/docs/src/contributing.md
@@ -31,7 +31,6 @@ If you're adding new files, make sure to `git add` them first.
 - All changes must be documented in the same PR.
 - You can run `m . /docs/dev` to serve the [docs site](https://makes.fluidattacks.tech)
   on localhost.
-- Make sure you lint the documentation with `m . /lintMarkdown/all`.
 
 #### Adding tests
 

diff --git a/makes.nix b/makes.nix
@@ -132,12 +132,6 @@
     config = "/test/lint-commit-msg/lint-git-commit-msg-config.js";
   };
   lintGitMailMap = { enable = true; };
-  lintMarkdown = {
-    all = {
-      config = "/test/lint-markdown/config.rb";
-      targets = [ "/" ];
-    };
-  };
   lintNix = {
     enable = true;
     targets = [ "/" ];

diff --git a/src/args/agnostic.nix b/src/args/agnostic.nix
@@ -63,7 +63,6 @@ let
       lintClojure = import ./lint-clojure/default.nix self;
       lintGitCommitMsg = import ./lint-git-commit-msg/default.nix self;
       lintGitMailMap = import ./lint-git-mailmap/default.nix self;
-      lintMarkdown = import ./lint-markdown/default.nix self;
       lintNix = import ./lint-nix/default.nix self;
       lintPython = import ./lint-python/default.nix self;
       lintPythonImports = import ./lint-python-imports/default.nix self;

diff --git a/src/args/lint-markdown/builder.sh b/src/args/lint-markdown/builder.sh
diff --git a/src/args/lint-markdown/default.nix b/src/args/lint-markdown/default.nix
diff --git a/src/evaluator/modules/default.nix b/src/evaluator/modules/default.nix
@@ -26,7 +26,6 @@
     (import ./lint-clojure/default.nix args)
     (import ./lint-git-commit-msg/default.nix args)
     (import ./lint-git-mailmap/default.nix args)
-    (import ./lint-markdown/default.nix args)
     (import ./lint-nix/default.nix args)
     (import ./lint-python/default.nix args)
     (import ./lint-terraform/default.nix args)

diff --git a/src/evaluator/modules/lint-markdown/config.rb b/src/evaluator/modules/lint-markdown/config.rb
diff --git a/src/evaluator/modules/lint-markdown/default.nix b/src/evaluator/modules/lint-markdown/default.nix
diff --git a/src/evaluator/modules/lint-markdown/rulesets.rb b/src/evaluator/modules/lint-markdown/rulesets.rb
diff --git a/test/lint-markdown/config.rb b/test/lint-markdown/config.rb