attac security issue

rohberg · Oct 31, 2024 · 2d9a0fd · 2d9a0fd
1 parent 3831908
commit 2d9a0fd
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/acceptance_monolingual.yml b/.github/workflows/acceptance_monolingual.yml
@@ -57,6 +57,9 @@ jobs:
 
       - uses: JarvusInnovations/background-action@v1
         name: Start Servers
+        env:
+          INDEX_PASSWORD: ${{ secrets.SECRET_INDEX_PASSWORD}}
+          PLONE_PASSWORD: ${{ secrets.SECRET_PLONE_PASSWORD}}
         with:
           run: |
             make ci-acceptance-backend-start-monolingual &

diff --git a/.github/workflows/acceptance_multilingual.yml b/.github/workflows/acceptance_multilingual.yml
@@ -57,6 +57,9 @@ jobs:
 
       - uses: JarvusInnovations/background-action@v1
         name: Start Servers
+        env:
+          INDEX_PASSWORD: ${{ secrets.SECRET_INDEX_PASSWORD}}
+          PLONE_PASSWORD: ${{ secrets.SECRET_PLONE_PASSWORD}}
         with:
           run: |
             make ci-acceptance-backend-start-multilingual &

diff --git a/Makefile b/Makefile
@@ -187,6 +187,8 @@ acceptance-frontend-prod-start-monolingual: ## Start acceptance frontend in prod
 
 .PHONY: acceptance-backend-start-monolingual
 acceptance-backend-start-monolingual: ## Start backend acceptance server
+    export INDEX_PASSWORD=paraDiesli,17
+    export PLONE_PASSWORD=secret
 	$(MAKE) -C "./backend/" acceptance-backend-start-monolingual
 
 .PHONY: ci-acceptance-backend-start-monolingual
@@ -215,6 +217,8 @@ acceptance-frontend-prod-start-multilingual: ## Start acceptance frontend in pro
 
 .PHONY: acceptance-backend-start-multilingual
 acceptance-backend-start-multilingual: ## Start backend acceptance server
+    export INDEX_PASSWORD=paraDiesli,17
+    export PLONE_PASSWORD=secret
 	$(MAKE) -C "./backend/" acceptance-backend-start-multilingual
 
 .PHONY: ci-acceptance-backend-start-multilingual

diff --git a/backend/dockerfiles/.env b/backend/dockerfiles/.env
@@ -3,15 +3,13 @@ export INDEX_NAME=plone
 export INDEX_OPENSEARCH=1
 export INDEX_USE_SSL=1
 export INDEX_LOGIN=admin
-export INDEX_PASSWORD=paraDiesli,17
 
 export CELERY_BROKER=redis://redis:6379/0
 export CELERY_LOGLEVEL=info
 
 export PLONE_SERVICE=http://backend-acceptance:55001
 export PLONE_SITE_PREFIX_PATH=plone
 export PLONE_USER=admin
-export PLONE_PASSWORD=secret
 
 export MAPPINGS_FILE=/configuration/mappings.json
 export ANALYSIS_FILE=/configuration/analysis.json