fix(theme): dark and light AppStore menu fix

[mauris]

Fixes #172
Fixes #173
Fixes #169

Hi @rohit-gohri, thanks for this amazing plugin. I noticed the issues described in those issues filed and am proposing a fix.

The issue was because we are initiating 2 copies of AppStore: one for dark and one for light. The last copy of AppStore successfully binds various scroll events to the window and hence was the only one able to receive the event. When in light theme, this doesn't work. I understood from the code that the 2 copies of AppStore were meant for ServerStyles to generate the dark and light stylesheets correctly.

I propose to only initiate 1 copy of AppStore and depending on the theme, update the options accordingly.

Feel free to clarify on the changes proposed. If this is alright, I'd like this fix to be published as soon as possible.

[changeset-bot]

⚠️ No Changeset found

Latest commit: a2fc365

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @rohit-gohri on Vercel.

@rohit-gohri first needs to authorize it.

[mauris]

sorry hold off, I realised there's an issue in the built copy. Let me fix it.