Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SMA and EMA calculations #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AnsharaFayazBeigh
Copy link

@AnsharaFayazBeigh AnsharaFayazBeigh commented Oct 4, 2024

Closes #16
Issue Reference: #16

I have put the updated file where I have put the SMA and EMA calculations!
Added SMA and EMA calculations to the stock price prediction model
Implemented calculations for Simple moving average and exponential moving average to improve the model's predictive abilities..

Added SMA and EMA calculations to the stock price prediction model
1. Implemented calculations for Simple moving average and exponential moving average to improve the model's predictive abilities..
@AnsharaFayazBeigh
Copy link
Author

The issue was #16
@rohitinu6
Please guide me what is the next step

@jvedsaqib
Copy link
Collaborator

@AnsharaFayazBeigh you created a new notebook?

@AnsharaFayazBeigh
Copy link
Author

Yes I did! @jvedsaqib

@AnsharaFayazBeigh
Copy link
Author

@rohitinu6 Please review It!

@jvedsaqib
Copy link
Collaborator

@AnsharaFayazBeigh can you do the changes on the actual notebook itself?
As new NB would create confusion.

Please star the repo if you haven't

@AnsharaFayazBeigh
Copy link
Author

@jvedsaqib Thanks for the feedback! I’ve been using Google Colab for the notebook, and I ended up having to create a new one to make everything work. Because of that, I can’t update the original notebook directly. Do you have any suggestions on how I can merge my changes, or what I should do next? I’d really appreciate any help! Thanks so much!

I did star the repo!

@jvedsaqib jvedsaqib added the level2 25 Points 🥈 label Oct 13, 2024
@AnsharaFayazBeigh
Copy link
Author

This PR addresses the issue #16
Can you also assign the labels to this PR ( hacktoberfest-accepted, gssoc-ext)?

@Mayureshd-18 Mayureshd-18 self-requested a review October 14, 2024 18:55
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mayureshd-18 Mayureshd-18 added gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 hacktoberfest Hacktober Collaboration labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 level2 25 Points 🥈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate feature engineering for enhanced model performance
3 participants