Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with AnyCable: undefined method `protocol' for nil:NilClass #304

Closed
wongy91 opened this issue Oct 17, 2019 · 3 comments · Fixed by #310 or gocutover/lograge#1
Closed

Issue with AnyCable: undefined method `protocol' for nil:NilClass #304

wongy91 opened this issue Oct 17, 2019 · 3 comments · Fixed by #310 or gocutover/lograge#1

Comments

@wongy91
Copy link

wongy91 commented Oct 17, 2019 •
edited
Loading

lograge/lib/lograge/rails_ext/action_cable/connection/base.rb

Line 8 in 2347f63

@protocol = websocket.protocol

where is the websocket object initialized?

Application error: undefined method protocol' for nil:NilClass Application error: undefined method protocol' for nil:NilClass
@jpalumickas
Copy link

We have the same problem

palkan added a commit to palkan/lograge that referenced this issue May 6, 2020
@palkan
Use prepend to patch Action Cable classes
3a5011e 
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g., Module#prepend

Fixes roidrage#304
@palkan palkan mentioned this issue May 6, 2020
Merged
palkan added a commit to palkan/lograge that referenced this issue May 6, 2020
@palkan
Use prepend to patch Action Cable classes
143767a 
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g., Module#prepend

Fixes roidrage#304
palkan added a commit to palkan/lograge that referenced this issue May 6, 2020
@palkan
Use prepend to patch Action Cable classes
41a772a 
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g., Module#prepend

Fixes roidrage#304
@palkan palkan mentioned this issue May 6, 2020
Closed
@danielnc
Copy link

we have same problem

jefflub pushed a commit to jefflub/lograge that referenced this issue Sep 8, 2020
@palkan @jefflub
Use prepend to patch Action Cable classes
e28579f 
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g., Module#prepend

Fixes roidrage#304
@marsadle marsadle mentioned this issue Nov 10, 2020
Merged
@uhrohraggy
Copy link

FYI This is still an open issue. anycable/anycable-rails#103 has more details on why this PR exists, and is desperately needed. Please review

@uhrohraggy uhrohraggy mentioned this issue Jun 17, 2021
Open
palkan added a commit to palkan/lograge that referenced this issue Jan 11, 2022
@palkan
Use prepend to patch Action Cable classes
103d827 
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g., Module#prepend

Fixes roidrage#304
palkan added a commit to palkan/lograge that referenced this issue Jan 20, 2022
@palkan
Use prepend to patch Action Cable classes
2c1a849 
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g., Module#prepend

Fixes roidrage#304
iloveitaly pushed a commit that referenced this issue Jan 24, 2022
@palkan
Use prepend to patch Action Cable classes (#310)
2fd03f7 
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g., Module#prepend

Fixes #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@danielnc @jpalumickas @uhrohraggy @wongy91