Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid version in Rack::Logger code comment #327

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

olleolleolle
Copy link
Contributor

This version mention could make it seem like it was no longer the case, but it is still the case, so by removing the version marker, this is less confusing.

The #before_dispatch code comment is still version-relevant, it seems.

This version mention could make it seem like it was no longer the case, but it is still the case, so by removing the version marker, this is less confusing.

The #before_dispatch code comment is still version-relevant, it seems.
@iloveitaly iloveitaly merged commit f2ce77d into roidrage:master Jan 11, 2022
@olleolleolle olleolleolle deleted the patch-2 branch January 11, 2022 15:49
olleolleolle added a commit to olleolleolle/lograge that referenced this pull request Jan 11, 2022
This version mention could make it seem like it was no longer the case, but it is still the case, so by removing the version marker, this is less confusing.

The #before_dispatch code comment is still version-relevant, it seems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants