Follow hash syntax for event["message"] for logstash-event v1.4.x #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this needs a rebase plus the test suite is sad. Is there any interest in having this landed in master still? |
|
This could be easily fixed. I am concerned if older versions would still work. |
|
I believe this change would only work with logstash gem version 1.3+. (which is why I put that comment there). As an aside, I also no longer actively use lograge so I don't really have a good testing framework to resolve "multi-version" logstash API changes. But... at least you know what may need to happen if you use the new logstash gem version. |
|
I just checked and the current version of |
pxlpnk
added a commit
to pxlpnk/lograge
that referenced
this pull request
Feb 1, 2015
This is a working version of roidrage#75. It will break backwards compability with < 1.4.x for logstash users.
2 tasks
pxlpnk
added a commit
to pxlpnk/lograge
that referenced
this pull request
Feb 1, 2015
This is a working version of roidrage#75. It will break backwards compability with < 1.4.x for logstash users.
|
This is fixed now with #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for people who are using the logstash gem version 1.3+.
They remove the event.message accessor and make you use the ["message"] format instead.