Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send viewport notification when a game is running without being connected (or a setting) #586

Closed
antipoly opened this issue Jul 22, 2022 · 9 comments
Assignees
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen

Comments

@antipoly
Copy link

Sometimes, but not too commonly, I'm running my game without Rojo being connected and not realising, spending some time attempting to troubleshoot the errors that I thought I had already fixed.

I think it's worth adding a visual indicator that tells us when we're not connected to Rojo, to prevent this type of issue. And for the many smart people who always double check, unlike me, there can be a setting to turn it on/off.

@boatbomber
Copy link
Member

The plugin toolbar button shows a little link icon when the plugin is connected, as a way to expose connected status without having the widget open.

@antipoly
Copy link
Author

The plugin toolbar button shows a little link icon when the plugin is connected
Yeah that's right, however we're not always on the plugin tab

@boatbomber
Copy link
Member

Hm. Perhaps, when you press play, it outputs a little warning if it finds an active serve that it's not connected to? That assumes you've already configured the port, cuz we won't be scanning every port.

@boatbomber
Copy link
Member

Well, I got a prototype working.
demo

In making this, I discovered some interesting design and limitation problems.

  1. Client can't make Http requests, so you'll only see the notification if you switch to server view in Accurate Play Solo (note the green outline in my demo image). You'll see the warning in the output, at least.
  2. It'll happen every time you play, since obviously it starts out not connected. This is very annoying.

Perhaps a little info on the connect page to let you know it found a serve? This doesn't really solve the problem though, as you may not be looking there or even have the widget open.
image

This issue needs more thought. Anyone want to weigh in?

@sasial-dev
Copy link
Contributor

Is it worth just waiting for #468 to be complete?

@boatbomber
Copy link
Member

That won't help the common case of forgetting to connect in Edit mode, @sasial-dev. That auto connects in Run mode when you've already connected in Edit mode.

@boatbomber boatbomber self-assigned this Jul 25, 2022
@boatbomber boatbomber added scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. labels Jul 25, 2022
@LPGhatguy
Copy link
Contributor

I'm not sure it's valid to nag the user to connect whenever there's a session running at all.

I think Rojo probably has a deeper workflow issue here. We should make the process of starting Rojo, opening Studio, and connecting a seamless operation. A user should be able to double-click a Rojo project and be off to the races.

Small fixes like this might solve some users forgetting to connect at the expense of users who don't want to connect getting a lot of unnecessary noise.

@boatbomber
Copy link
Member

My solution in PR #588 allows them to hit ignore, so it would not be a ton of noise at least, just the one nudge. I do agree that we should have a smoother flow overall, but this can still potentially be a valid short term measure.

@LPGhatguy
Copy link
Contributor

I think that even with an ignore switch, this is a feature that's in the wrong direction. Ignoring isn't persisted in any way, so it'll still pop up at least once. Storing which places have ignored the prompt diminishes the value of the feature, but not storing them still annoys people we don't need to ignore.

Instead of this band-aid, let's think about what the longer term workflow looks like for Rojo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants