Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform non-connected users of active serves #588

Closed
wants to merge 9 commits into from

Conversation

boatbomber
Copy link
Member

@boatbomber boatbomber commented Jul 23, 2022

Resolves #586.

Oftentimes users forget to connect to their served project, and waste time "debugging" when really their changes just aren't synced. This PR adds a periodic check for served projects when you're not already connected, and will notify you (and output a Log.warn) if there's a serve that you're not connected to.
Notification GUIs now have action buttons on them, smoothing out the process of responding to their contents.

image

Pressing "Connect" will connect to the served project. Pressing "Ignore" will add that project name to an ephemeral ignore list so it will stop notifying you about that particular served project for the remainder of this Studio session, resetting the ignore list next time you open Studio.

Of course, you can disable all of this with a setting.

image


To Do:

  • Redesign notification UI to allow for buttons
  • Add actions to notifications
  • Add function to find served project
  • Periodically search for served project while not connected
  • Add setting to disable periodic scans
  • Break the scan loop on App unmount

@boatbomber boatbomber added the status: needs review This work is mostly done, but just needs work to integrate and merge it. label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review This work is mostly done, but just needs work to integrate and merge it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send viewport notification when a game is running without being connected (or a setting)
1 participant