Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linux release runner to use ubuntu-18.04 #561

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

JohnnyMorganz
Copy link
Contributor

ubuntu-latest uses Ubuntu 20.04, this causes issues with glibc as older versions of ubuntu/other distros use an older version.

This is fixed by building the release binary on ubuntu-18.04, which uses a version of glibc more widely available.

Ref: JohnnyMorganz/StyLua#444
JohnnyMorganz/StyLua#445

ubuntu-latest uses Ubuntu 20.04, this causes issues with glibc as older versions of ubuntu/other distros use an older version.

This is fixed by building the release binary on `ubuntu-18.04`, which uses a version of glibc more widely available.

Ref: JohnnyMorganz/StyLua#444
JohnnyMorganz/StyLua#445
Copy link
Contributor

@LPGhatguy LPGhatguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We'll get this into the next release.

@LPGhatguy LPGhatguy merged commit f9b7774 into rojo-rbx:master Jun 26, 2022
@JohnnyMorganz JohnnyMorganz deleted the patch-1 branch June 26, 2022 19:26
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
ubuntu-latest uses Ubuntu 20.04, this causes issues with glibc as older versions of ubuntu/other distros use an older version.

This is fixed by building the release binary on `ubuntu-18.04`, which uses a version of glibc more widely available.

Ref: JohnnyMorganz/StyLua#444
JohnnyMorganz/StyLua#445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants