-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PollWatcher in memofs StdBackend on macOS #783
Use PollWatcher in memofs StdBackend on macOS #783
Conversation
Ok, looks like the issue is confined to serve tests only (it works as expected during real usage). I'll work on sussing out the cause |
Would it be ok to just put this behind a |
OK, so I got @sasial-dev to test this and serve tests pass using PollWatcher on macOS [???] I'll gladly take this, but it's pretty spooky so we should investigate further |
I am uncomfortable with this set of problems because it feels suspiciously like a race condition. You can read the core loop of My suspicion is that we're deadlocking somewhere because Github CI runners only have 2 cores. This limits the amount of threads we can run quite severely. On local machines, this limit is bypassed even if you limit the number of jobs Either way, I don't think this is a problem we need to worry about. I'm comfortable enough with my audit that I'm willing to approve this since I don't believe it's some deep seated systemic bug in Notify. |
This reverts commit 3cafbf7.
This reverts commit 3cafbf7.
This should hopefully finally put to rest the extreme slowness on macOS. Taken from UpliftGames#2.
Looks like it fails end to end serve tests because write events are never received...☹Interestingly, this is similar to something that @sasial-dev observed a little while ago in the OSS Discord server, I wonder if it's related? It might tank this whole PR, unfortunately