Remove maplit dependency and stop using a macro for hashmaps #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
added
the
skip changelog
|
Okay, there's a chance that this will just make adopting a new Hasher annoying. We shall see. |
kennethloeffler
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Nice, maplit is pretty crusty and I'm glad to see it go.
Okay, there's a chance that this will just make adopting a new Hasher annoying. We shall see.
I think we should able to do .into_iter().collect() after adopting a different hasher, which isn't as compact as just .into(), but still not bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm tired of this macro. It will cause us trouble down the line when we try to swap to a faster hashmap, and it's just not idiomatic.
So, I have removed it. In practice this mostly impacts tests.