Add do while (0) to Id and ID macros #437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ID and Id macros were giving me syntax warnings saying a ";" was missing anytime I used them, which was very annoying as in my IDE (STM32Cube) it filled the code (even other lines) with underlining, making it a bit unreadable.
To fix it I added do {} while (0) to those to macros, and the error disappeared.
I suppose it's possible that other people, especially in other IDEs were not getting this warning but I think my proposed changes only improve the code for people with the same problem as me and will not affecting others.
If you wish to make any change or want me to make any change before merging, feel free to!