Correctly eliminate destructuring assignment (vercel#13144)

This eliminates code referenced via destructuring assignment, as reported by @styfle.
rokinsky · Jul 11, 2020 · d03c923 · d03c923
1 parent 9007c1f
commit d03c923
Show file tree

Hide file tree

Showing 2 changed files with 88 additions and 14 deletions.
diff --git a/packages/next/build/babel/plugins/next-ssg-transform.ts b/packages/next/build/babel/plugins/next-ssg-transform.ts
@@ -189,13 +189,33 @@ export default function nextTransformSsg({
           path.traverse(
             {
               VariableDeclarator(path, state) {
-                if (path.node.id.type !== 'Identifier') {
-                  return
-                }
-
-                const local = path.get('id') as NodePath<BabelTypes.Identifier>
-                if (isIdentifierReferenced(local)) {
-                  state.refs.add(local)
+                if (path.node.id.type === 'Identifier') {
+                  const local = path.get('id') as NodePath<
+                    BabelTypes.Identifier
+                  >
+                  if (isIdentifierReferenced(local)) {
+                    state.refs.add(local)
+                  }
+                } else if (path.node.id.type === 'ObjectPattern') {
+                  const pattern = path.get('id') as NodePath<
+                    BabelTypes.ObjectPattern
+                  >
+
+                  const properties = pattern.get('properties')
+                  properties.forEach((p) => {
+                    const local = p.get(
+                      p.node.type === 'ObjectProperty'
+                        ? 'value'
+                        : p.node.type === 'RestElement'
+                        ? 'argument'
+                        : (function () {
+                            throw new Error('invariant')
+                          })()
+                    ) as NodePath<BabelTypes.Identifier>
+                    if (isIdentifierReferenced(local)) {
+                      state.refs.add(local)
+                    }
+                  })
                 }
               },
               FunctionDeclaration: markFunction,
@@ -319,14 +339,44 @@ export default function nextTransformSsg({
             path.traverse({
               // eslint-disable-next-line no-loop-func
               VariableDeclarator(path) {
-                if (path.node.id.type !== 'Identifier') {
-                  return
-                }
+                if (path.node.id.type === 'Identifier') {
+                  const local = path.get('id') as NodePath<
+                    BabelTypes.Identifier
+                  >
+                  if (refs.has(local) && !isIdentifierReferenced(local)) {
+                    ++count
+                    path.remove()
+                  }
+                } else if (path.node.id.type === 'ObjectPattern') {
+                  const pattern = path.get('id') as NodePath<
+                    BabelTypes.ObjectPattern
+                  >
+
+                  const beforeCount = count
+                  const properties = pattern.get('properties')
+                  properties.forEach((p) => {
+                    const local = p.get(
+                      p.node.type === 'ObjectProperty'
+                        ? 'value'
+                        : p.node.type === 'RestElement'
+                        ? 'argument'
+                        : (function () {
+                            throw new Error('invariant')
+                          })()
+                    ) as NodePath<BabelTypes.Identifier>
+
+                    if (refs.has(local) && !isIdentifierReferenced(local)) {
+                      ++count
+                      p.remove()
+                    }
+                  })
 
-                const local = path.get('id') as NodePath<BabelTypes.Identifier>
-                if (refs.has(local) && !isIdentifierReferenced(local)) {
-                  ++count
-                  path.remove()
+                  if (
+                    beforeCount !== count &&
+                    pattern.get('properties').length < 1
+                  ) {
+                    path.remove()
+                  }
                 }
               },
               FunctionDeclaration: sweepFunction,

diff --git a/test/unit/babel-plugin-next-ssg-transform.test.js b/test/unit/babel-plugin-next-ssg-transform.test.js
@@ -452,5 +452,29 @@ describe('babel plugin (next-ssg-transform)', () => {
         `"export var __N_SSG=true;export default function Home(){return __jsx(\\"div\\",null);}"`
       )
     })
+
+    it('destructuring assignment (object)', () => {
+      const output = babel(trim`
+        import fs from 'fs';
+        import other from 'other';
+
+        const {readFile, readdir, access: foo} = fs.promises;
+        const {a,b, cat: bar,...rem} = other;
+
+        export async function getStaticProps() {
+          readFile;
+          readdir;
+          foo;
+          b;
+          cat;
+          rem;
+        }
+        export default function Home() { return <div />; }
+      `)
+
+      expect(output).toMatchInlineSnapshot(
+        `"import other from'other';const{a,cat:bar}=other;export var __N_SSG=true;export default function Home(){return __jsx(\\"div\\",null);}"`
+      )
+    })
   })
 })