Review changes - stephentoub dotnet#2

rokonec · Nov 26, 2020 · d6b6252 · d6b6252
1 parent 3bcd31d
commit d6b6252
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/Huffman.cs b/src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/Huffman.cs
@@ -7,9 +7,9 @@
 
 namespace System.Net.Http.HPack
 {
-    internal class Huffman
+    internal static class Huffman
     {
-        private static ushort[]? s_decodingTree;
+        private static ushort[] s_decodingTree = GenerateDecodingLookupTree();
 
         // HPack static huffman code. see: https://httpwg.org/specs/rfc7541.html#huffman.code
         private static readonly (uint code, int bitLength)[] _encodingTable = new (uint code, int bitLength)[]
@@ -413,10 +413,6 @@ public static int Decode(ReadOnlySpan<byte> src, ref byte[] dstArray)
             Span<byte> dst = dstArray;
             Debug.Assert(dst != null && dst.Length > 0);
 
-            if (s_decodingTree == null)
-            {
-                Volatile.Write(ref s_decodingTree, GenerateDecodingLookupTree());
-            }
             ushort[] decodingTree = s_decodingTree;
 
             int lookupTableIndex = 0;