Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support Brighterscript v1 #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markwpearce
Copy link
Contributor

Changes:

  • pulls out comments from leading trivia
  • small code changes to support AST node differences

@markwpearce
Copy link
Contributor Author

@TwitchBronBron This fails due to a lint error because it's checking node_modules ?

node_modules/brighterscript/dist/parser/Statement.d.ts:9:15 - error TS1005: ',' expected.

9 import { type GetTypeOptions, type TranspileResult, type TypedefProvider } from '../interfaces';
                ~~~~~~~~~~~~~~

node_modules/brighterscript/dist/parser/Statement.d.ts:9:36 - error TS1005: ',' expected.

9 import { type GetTypeOptions, type TranspileResult, type TypedefProvider } from '../interfaces';
                                     ~~~~~~~~~~~~~~~

@TwitchBronBron
Copy link
Member

@markwpearce I think that error is because we're using a slightly older version of typescript. I upgraded typescript in a recent release, so if we resolve the conflicts and merge master, this issue might fix itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants