-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Native Brightscript Component Types and Custom Components (Nodes) to Type System #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n global SymbolTable
TwitchBronBron
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Just a few comments and then this is good to go.
TwitchBronBron
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
roDeviceInfo
,roBitmap
,roDateTime
, etc.) as types usable in Brighterscript, including completions on methods and documentationifDraw2d
,ifAppManager
, etc)roInputEvent
,roSGNodeEvent
)AssociativeArrayType
that can be built from an AA literal (eg.myAA = {name: "Mark", coolFactor: 100}
, and will correctly be compatible with interface types that have declared the same members, eg:Adds Scenegraph nodes to type system. The type's name is the component's name prefixed with
roSGNode
... soroSGNodePoster
,roSGNodeRowList
,roSGNodeStdDlgTextItem
are all available as types (with completions, documentation, etc)Custom components are also added (again, prefixed with
roSgNode
). Eg:will create a type in the type system with name
roSGNodeWidget
, with completions and type inferences for propertiesalpha
,beta
,charlie
, as well as validation on methods like'getChildren()
,subType()
, etc.NOTE: CallFunc's are a pain, because they cross scope boundaries. More work needs to be done to fully support callFuncs with validation and return type inference