Language Server Rewrite #993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support cancelling validate
* Fix issues with the .gitignore loading for pathFilterer * Apply suggestions from code review --------- Co-authored-by: Christopher Dwyer-Perkins <chris@inverted-solutions.com>
…1327) * rebuildPathFilterer now retains project-specific patterns on rebuild * Add test to verify removed project includeLists get unregistered
* rebuildPathFilterer now retains project-specific patterns on rebuild * Add test to verify removed project includeLists get unregistered * Include more information in the busy tracker * Fix lint issues
* Fix infinite loop issue with standalone projects * Fix failing tests * Tweaks
* Cancel requests to disposed projects * Fix broken package-lock
* Cancel requests to disposed projects * Fix broken package-lock * Do not reload project if bsconfig contents are unchanged
…1362) * Emit `active-runs-change` event _after_ removing it from the array. * Remove `.only` (gotta stop doing that...)
* Prevent simultaneous validate() for same project (was causing lost diagnostics) * Fix lint issues * Throw exceptions in sequencer (to ensure we don't get stuck in validate forever)
…ed (#1381) * Prevent simultaneous validate() for same project (was causing lost diagnostics) * Fix lint issues * Throw exceptions in sequencer (to ensure we don't get stuck in validate forever) * Emit the `afterProgramValidate` event even when validation is cancelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some significant performance issues in the language server, focused around when files are opened/edited/closed from the editor. To mitigate this, we need to refactor the language server so that it's better about throttling/debouncing ALL the relevant files instead of just one at a time.
This is a fairly significant refactor of the language server code, and breaks it down into more manageable classes.
Task list
ProjectManagerand other new logicLanguageServer.ts.roku-deploy-staging, .git, and other ignored foldersProcess for excluding files:
Build a global list of filters, based on:
- globs from
files.exclude- globs from
.gitignore(maybe using this?)- all files in ".git", and every workspaceFolder.outDir.
Also produce a per-project list of file globs based on the project's bsconfig (or default)
In the lsp, in onWatchedFilesChanged, filter out any files that match zero of the patterns from above (handling negated .gitignore results and files.exclude).