forked from uc-cdis/fence
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge upstream into master #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(PXP-7717): Implement ad-hoc usersync for single user after logging in through RAS
PXP-7529: sign download urls where no_force_sign=False
Co-authored-by: Pauline Ribeyre <ribeyre@uchicago.edu>
* store expires_in param from authz request in flask session * take expires_in value from session if present for generating refresh tokens * fix key check * debug * revert * add exp col to auth code db table model * extract expires_in param from authorize request and put in db record * add refresh_token_expires_in logic to token response * add code for db migration authorization_code table add col * remove comment * reformat * handle pre-db migration case * undo last change * handle pre-db-migration case * fix init auth code record * undo last change * revert * try reflecting db to enable backwards compatibility with previous db schema * add ref to relevant doc * fix db reflection * add scope handling * reflect auth code table at token endpoint * revert * Accommodate variously named query params for expiration times * expiry does not always refer to access token * Refactor get-and-validate-requested-expiration pattern into util fn * Clearer intentions, better names, less repetition, less cognitive load, etc Co-authored-by: vpsx <19900057+vpsx@users.noreply.github.com>
Fix/delete with no urls
…/fence into fix/usersync-update-role merge
(PXP-7539): Fix/populate idp for user info
Fix/usersync update role
…n-idp-not-in-LOGIN_OPTIONS-cfg (PXP-7319): Fix oauth flow when fence idp not in LOGIN_OPTIONS
rolinge
pushed a commit
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description about what this pull request does.
merge upstream into master
Please make sure to follow the DEV guidelines before asking for review.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes