Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RollbarPLCrashReporter library. #246

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Remove RollbarPLCrashReporter library. #246

merged 3 commits into from
Jan 12, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jan 12, 2023 •
edited
Loading

Description of the change

Taking a few steps to simplify how we collect crashes. I'm dropping this library in favor of another that does a better job of capturing OS signals.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jan 12, 2023
cyrusradfar
cyrusradfar suggested changes Jan 12, 2023
View reviewed changes
Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the ticket and then resubmit.

Demos/iosAppSwift/iosAppSwift/iosAppSwiftApp.swift Outdated Show resolved Hide resolved
cyrusradfar
cyrusradfar approved these changes Jan 12, 2023
View reviewed changes
Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I appreciate how you improved that clarity of the code and shortened it. Quite an accomplishment.

@matux matux merged commit b448c69 into collect_crashes_with_stacktraces Jan 12, 2023
@matux matux deleted the consolidate_dep branch January 12, 2023 23:19
@matux matux mentioned this pull request Jan 17, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrusradfar cyrusradfar cyrusradfar approved these changes

@ijsnow ijsnow Awaiting requested review from ijsnow

Assignees

@matux matux

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matux @cyrusradfar