Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the native Rollbar/Android SDK as a hook instead of explicitly #110

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 2, 2023

Description of the change

This PR encapsulates the initialization of the Rollbar/Android (native) SDK as another Hook, called the NativeHook.

This PR also encapsulate inside the PlatformHook the as dynamic hack we use to check whether the PlatformDispatcher.onError closure exists.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #129017: Flutter SDK isn't catching async errors.

@matux matux merged commit 5e5823a into main Aug 2, 2023
2 checks passed
@matux matux deleted the native_hook branch August 2, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants