Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed platform related compilation issues with updated ext libs #68

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 9, 2022

Description of the change

Fixed some compilation issues related to platforms and updated sqlite3 libs:

  • Updated sqlite3 libraries
  • Fixed Java linter issue with lexicographical ordering of imports
  • Fixed newer libs not compiling on iOS due to a very low minimum deployment iOS version (was 8, now it's 9)

CI is currently failing due to an issue with pana checks. This will be fixed in another PR.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Aug 9, 2022
@matux matux requested a review from akornich August 9, 2022 16:15
Copy link
Contributor

@akornich akornich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is no harm keeping Podfile.lock under git control but maybe makes sense to ignore it...

rollbar_flutter/example/ios/Podfile.lock Show resolved Hide resolved
@matux matux merged commit 80a6407 into main Aug 9, 2022
@matux matux deleted the maintenance branch August 9, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update sqlite3_flutter_libs above 3.5.8 due to a project config error
2 participants