Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dart compilation issue. #77

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Fixed Dart compilation issue. #77

merged 1 commit into from
Oct 26, 2022

Conversation

matux
Copy link
Collaborator

@matux matux commented Oct 21, 2022

Description of the change

Fixed an obscure compilation issue that arose while working on the current features. The error thrown by the analyzer/compiler is neither correct nor particularly precise, but it led to an improvement in how we express persistable records, which fixed the complain.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Oct 21, 2022
Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the attention to detail in the error handling, Matias. Thank you, approved.

@matux matux merged commit 5e0adc0 into main Oct 26, 2022
@matux matux deleted the generic_issue branch October 26, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surfaced generics-related compilation error
2 participants