Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an Android native unit test and Android example issue #96

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Conversation

matux
Copy link
Collaborator

@matux matux commented Mar 14, 2023

Description of the change

An Android unit test started to fail with Flutter SDK 3.7.

The function encodeErrorEnvelopeWithStacktrace on our mocked MethodCodec is being called without a stack trace, this call comes from the Flutter system. I've tracked this down to:

Where "errorStacktrace - Platform stacktrace for the error. possibly null."

So it seems it is correct that this may be null. I've added a check.

The library and example works fine regardless of the Flutter SDK version.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

  • This issue isn't being tracked.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Mar 14, 2023
@matux matux requested a review from ijsnow March 14, 2023 23:11
@matux matux merged commit 69d3c5d into main Mar 14, 2023
@matux matux deleted the issues branch March 14, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants