Extend Exception Level Filter configuration to accept lambda applied to all exceptions #1125
+172
−77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Exception level filters configuration allows to specify level (directly or through a lambda) for explicit class names but we reach a limit when using inheritance or more generally want the level to be determined by a lambda for distinct exception classes without having to go through declaring each single classes in the configuration.
With this change we could get this to work
This change is basic and just add another configuration, it could be interesting to have the exception_level_filter chainable similarly to how the current implementation uses the
.merge!
to add behaviour without resetting the entire configuration but this is probably for another iteration...Type of change
Related issues
Checklists
Development
Code review