Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- fix: resolve #340: Cocoapods build failing under Xcode 12.0 #341

Merged
merged 1 commit into from
Dec 1, 2020
Merged

- fix: resolve #340: Cocoapods build failing under Xcode 12.0 #341

merged 1 commit into from
Dec 1, 2020

Conversation

akornich
Copy link
Contributor

@akornich akornich commented Dec 1, 2020

Description of the change

fix: resolve #340: Cocoapods build failing under Xcode 12.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

#340

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@akornich akornich self-assigned this Dec 1, 2020
@akornich
Copy link
Contributor Author

akornich commented Dec 1, 2020

@waltjones , thank you!

@akornich akornich merged commit 77d586d into rollbar:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

@mrunalk mrunalk Awaiting requested review from mrunalk

@ajtran ajtran Awaiting requested review from ajtran

@natesweet natesweet Awaiting requested review from natesweet

@letaniaferreira letaniaferreira Awaiting requested review from letaniaferreira

Assignees

@akornich akornich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cocoapods build failing under Xcode 12.0
2 participants
@akornich @waltjones