Support whether data comes from an uncaught exception or not #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basoko
reviewed
Feb 10, 2018
| @@ -21,6 +21,27 @@ | |||
| */ | |||
There was a problem hiding this comment.
I think we can mark this method as deprecated.
There was a problem hiding this comment.
I was trying to change this interface so that this change would not be a breaking change by deprecating this and providing a default implementation of the method below. But it looks like default interface implementations are not supported before Java 8, so the only thing I can see to do is to make a semver major breaking change.
There are certain use cases where people want to know if a set of data comes from an uncaught exception or not. Add this information to the data object and to the filter interface. This way we can use our existing filter and transform infrastructure for dealing with this data. Fixes #93
rokob
force-pushed
the
add-uncaught-info
branch
from
171489c
to
b11ff8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain use cases where people want to know if a set of data
comes from an uncaught exception or not. Add this information to the
data object and to the filter interface. This way we can use our
existing filter and transform infrastructure for dealing with this data.
Fixes #93