Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sending complete JSON payloads, as proxy for other SDKs #180

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Apr 10, 2019

Enables the public interface for rollbar-android: void sendJsonPayload(String json)

This supports Cordova apps by allowing the Java env to handle sending Rollbar events for the JS env. This also means each of the SDKs (At least Java, iOS, and rollbar.js) should agree on the interface definition, and be able to support it.

@rokob
Copy link
Contributor

rokob commented Apr 12, 2019

Do we want to do all the work somewhere else and have this just be a proxy or do we want to send structured data over here and let this SDK handle truncation, scrubbing, etc? For what this is going to be used for just the proxy route seems fine for now, but we might want to think how this could be done to have the native code do more of the heavy lifting.

@ArturMoczulski
Copy link
Contributor

LGTM as well :)

@waltjones
Copy link
Contributor Author

@rokob I'd love to discuss pros/cons of where would be optimal. After conversion to a string is the lowest marshaling complexity, though it would still be possible to do truncation after that point. I'm not sure I'm seeing a clear benefit.

One benefit of getting as close to the API request as possible is that any of the SDKs could probably conform to this pattern. It was certainly a win that at least JS, Java, and iOS all could.

Are there specific parts that could be handled better outside the environment where the logging and error handling happen?

@waltjones waltjones changed the title WIP: Enable sending complete JSON payloads, as proxy for other SDKs Enable sending complete JSON payloads, as proxy for other SDKs Apr 25, 2019
@waltjones waltjones merged commit 3d1731e into master Apr 26, 2019
ArturMoczulski added a commit that referenced this pull request Apr 29, 2019
@vselvarajijay vselvarajijay deleted the wj-cordova branch May 22, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants