Fix for a 403 error response from Nginx #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems possible to access ROllbar's servers and get a 403 Forbidden response. The code didn't handle this well at all since it always expects a json response from the server. This patch checks if the regex matcher successed and gracefully returns an error response so you can actually determine what is going on.
|
Great that for that problem $olve |
basoko
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems possible to access Rollbar's servers and get a 403 Forbidden response.
The code didn't handle this well at all since it always expects a json response
from the server.
This patch checks if the regex matcher succeeded and gracefully returns an error
response so you can actually determine what is going on.