Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all request parameters for post request method #243

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Add all request parameters for post request method #243

merged 1 commit into from
Dec 10, 2020

Conversation

basoko
Copy link
Contributor

@basoko basoko commented Dec 9, 2020 •
edited
Loading

Description of the change

The RequestProvider was only adding request parameters when the request method is GET. After this change it should track those parameters for POST method as well.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@basoko basoko force-pushed the basoko/track-request-parameters-with-every-method branch from 0372f48 to 2d464e5 Compare December 9, 2020 16:51
@basoko basoko force-pushed the basoko/track-request-parameters-with-every-method branch from 2d464e5 to e0eeb0a Compare December 9, 2020 17:04
@basoko basoko changed the title Add all request parameters independently of the request method Add all request parameters for post request method Dec 9, 2020
@basoko basoko merged commit 09c4351 into master Dec 10, 2020
@basoko basoko deleted the basoko/track-request-parameters-with-every-method branch December 10, 2020 10:40
This was referenced Mar 16, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones Awaiting requested review from waltjones

@mrunalk mrunalk Awaiting requested review from mrunalk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@basoko