Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable maven publishing for rollbar-reactive-streams and rollbar-reac… #297

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Enable maven publishing for rollbar-reactive-streams and rollbar-reac… #297

merged 1 commit into from
Nov 8, 2022

Conversation

diegov
Copy link
Contributor

@diegov diegov commented Nov 7, 2022 •
edited
Loading

Description of the change

Enable maven publishing for rollbar-reactive-streams and rollbar-reactive-streams-reactor artifacts.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

  • [sc116280]

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@diegov diegov requested a review from ncapilla November 8, 2022 09:07
ncapilla
ncapilla reviewed Nov 8, 2022
View reviewed changes
build.gradle Show resolved Hide resolved
@diegov diegov force-pushed the diegoveralli/publish_reactivestreams branch from c7115ec to f7e7b8d Compare November 8, 2022 14:21
@diegov diegov requested a review from ncapilla November 8, 2022 14:22
ncapilla
ncapilla approved these changes Nov 8, 2022
View reviewed changes
Copy link

@ncapilla ncapilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegov diegov merged commit c77e17e into master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncapilla ncapilla ncapilla approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegov @ncapilla