Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build:all and install-all scripts #117

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Added build:all and install-all scripts #117

merged 1 commit into from
Feb 29, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 29, 2024

Description of the change

This PR adds two tiny scripts:

  • build:all builds the library and taps into a new scripts which iterates through each directory in the examples directory to build every project.
  • ./scripts/install-all.ts [ci] is a script that npm installs/ci the library and iterates through each example and does the same.

The CI workflow has been updated to use this, and a new non-cache job was added to make sure npm install doesn't stop working due to a bad package.json. See: #115.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux requested a review from mudetroit February 29, 2024 15:47
@matux matux self-assigned this Feb 29, 2024
@matux matux force-pushed the matux/build-all branch 4 times, most recently from 3608b4b to 4746fae Compare February 29, 2024 16:04
mudetroit
mudetroit previously approved these changes Feb 29, 2024
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now, later if we get a real monorepo going that tooling should take over.

@matux matux merged commit a0b8f54 into main Feb 29, 2024
7 checks passed
@matux matux deleted the matux/build-all branch February 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants