Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add typings to Provider #27

Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix: Add typings to Provider #27

merged 1 commit into from
Jan 25, 2022

Conversation

quinnturner
Copy link
Contributor

Description of the change

Adds TypeScript types to Provider

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Related: #26 (comment)

@quinnturner quinnturner mentioned this pull request Jan 25, 2022
Merged
12 tasks
@calvinf
Copy link

calvinf commented Jan 25, 2022

Brilliant. LGTM.

waltjones
waltjones approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waltjones waltjones merged commit bb926a4 into rollbar:main Jan 25, 2022
@calvinf
Copy link

calvinf commented Jan 25, 2022 •
edited
Loading

@waltjones you are a hero, thank you!
@quinnturner you are a hero, thank you!

@quinnturner quinnturner deleted the typing-provider branch January 25, 2022 23:58
@calvinf calvinf mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quinnturner @calvinf @waltjones