Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import hooks from react #34

Merged
merged 1 commit into from
Feb 16, 2022
Merged

import hooks from react #34

merged 1 commit into from
Feb 16, 2022

Conversation

ijsnow
Copy link
Contributor

@ijsnow ijsnow commented Feb 16, 2022 •
edited
Loading

Description of the change

Fixes one of the bugs mentioned in #22 by importing functions used in the file.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@ijsnow ijsnow mentioned this pull request Feb 16, 2022
Closed
@waltjones waltjones self-requested a review February 16, 2022 12:19
waltjones
waltjones approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waltjones waltjones merged commit 1e89b54 into rollbar:main Feb 16, 2022
@waltjones waltjones mentioned this pull request Feb 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijsnow @waltjones