Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use most specific error name #781

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Conversation

waltjones
Copy link
Contributor

Grouping works best when the SDK sends the most specific error name available. Usually that's error.name, however there are known cases where error.constructor.name is more specific. (DOMException, for example)

This PR follows these rules:

  • Prefers any value over an empty string
  • Prefers any value over 'Error' where possible
  • Prefers name over constructor.name when both are more specific than 'Error'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant