added "enabled" field for notification rule #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9879943504Details
💛 - Coveralls |
matux
reviewed
Jul 10, 2024
There was a problem hiding this comment.
This looks all good to me, but I'm neither knowledgeable enough in Go nor Terraform to give a confident approval. So I'll wait for @waltjones to give it a look, too.
| # the head of the pull request instead of the merge commit. | ||
| - run: git checkout HEAD^2 | ||
| if: ${{ github.event_name == 'pull_request' }} | ||
|
|
There was a problem hiding this comment.
Why are these changes necessary? Incl. removing the on push branches/tags (L5-6), and adding permissions (L14-18).
There was a problem hiding this comment.
just merging @waltjones changes from PR #403
|
Code Climate has analyzed commit d4d5339 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.0% (0.0% change). View more on Code Climate. |
waltjones
approved these changes
Jul 10, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added
enabledboolean field (true/false) for rule notification.The change is backward compatible; disabled rule (enabled = false) will not be triggered.
The field is set to true by default.
Type of change
Checklists
Development
Code review