feat: add oxc jsxInclude and jsxExclude #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
reviewed
Oct 18, 2024
Comment on lines
200
to
203
| // disable refresh at ssr | ||
| if (options?.ssr && oxcTransformOptions.jsx?.refresh) { | ||
| oxcTransformOptions.jsx.refresh = false | ||
| } |
There was a problem hiding this comment.
Just to confirm, this refresh option is only for React and won't be used by other JSX frameworks, right? (If it can be used then, I guess we cannot use the assumption that refresh should be false for ssr.)
There was a problem hiding this comment.
I'm not sure other JSX frameworks hmr how to works. Let me check it.
There was a problem hiding this comment.
- preact using
Prefresh-babelhttps://github.com/preactjs/prefresh/blob/main/packages/babel/README.md - solid using
solid-refresh/babelhttps://github.com/solidjs/solid-refresh
I think it is only for react at now. We could change it if here found other cases.
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Conside the react plugin has two edge case
refreshat internaljsxIncludeoption to do it.