This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Fraud Proof generation and partial verification using IAVL store #1
feat: Fraud Proof generation and partial verification using IAVL store #1
Changes from all commits
51d06e8
9396aab
1975e89
8168e32
20e50ff
9801e3e
b3737ae
a841e31
afda438
e9e96ef
255115b
3730b3c
f61fc8d
f47e13f
cd8e9cf
3a5ebed
4587509
3d27e3e
afc7229
edcefbb
e0b809f
7ca2868
d3279d0
3f51f21
2ee763e
d3bba65
48b968c
f52e1e2
536d58b
6a6c843
d3e0a32
19edc8e
da75457
7db9131
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is calling panic a standard pulled from the cosmos sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for
ABCI
methods, if something goes wrong, there's no way to gracefully throw an error other thanpanic
. If you look at theBeginBlock
implementation, you'll seepanic
calls.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any situation when this can happen? Because of pruning settings, genesis block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happens when there is no last state to load form, added a inline comment mentioning it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about chain updates?
See: https://github.com/cosmos/cosmos-sdk/blob/a34d5b213d1d0e6ffbba2e9d4841eb894f933527/baseapp/abci.go#L93-L103
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added "chain update" case in rollkit/rollkit#518
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "dummy" enough? What about other params in
RequestBeginBlock
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented in rollkit/rollkit#572
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need to export this function? It seems it's used only in
SetupBaseAppFromFraudProof
, so it can be private.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in #4