Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add ABCI methods for Fraud Proof Generation #43

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

Manav-Aggarwal
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal commented Aug 24, 2022

Adds the following methods required for fraudproof generation to the ABCI interface:

  1. GetAppHash () -> appHash
  2. TriggerFraudProofGenerationMode () -> ModeEnabledSuccess
  3. GenerateFraudProof () -> FraudProof

Fraud Proof type described in celestiaorg/cosmos-sdk#248

Closes: #4

@Manav-Aggarwal Manav-Aggarwal changed the base branch from fraudproof_abci_interface to abci_fraud_proofs August 24, 2022 02:45
@Manav-Aggarwal Manav-Aggarwal linked an issue Aug 24, 2022 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal self-assigned this Aug 24, 2022
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review August 24, 2022 02:46
@Manav-Aggarwal Manav-Aggarwal changed the title Manav/abci add generate Add ABCI methods for Fraud Proof Generation Aug 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (abci_fraud_proofs@a41c5ee). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             abci_fraud_proofs      #43   +/-   ##
====================================================
  Coverage                     ?   45.86%           
====================================================
  Files                        ?      279           
  Lines                        ?    51244           
  Branches                     ?        0           
====================================================
  Hits                         ?    23504           
  Misses                       ?    25873           
  Partials                     ?     1867           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address linter issues (split long lines). Other than that, LGTM.

proto/tendermint/abci/types.proto Outdated Show resolved Hide resolved
Manav-Aggarwal and others added 2 commits October 11, 2022 03:41
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
@tzdybal tzdybal merged commit f0611ba into abci_fraud_proofs Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ABCI methods for Fraud Proof Generation
4 participants