This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
forked from tendermint/tendermint
-
Notifications
You must be signed in to change notification settings - Fork 3
Add ABCI methods for Fraud Proof Generation #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manav-Aggarwal
changed the base branch from
fraudproof_abci_interface
to
abci_fraud_proofs
August 24, 2022 02:45
Manav-Aggarwal
changed the title
Manav/abci add generate
Add ABCI methods for Fraud Proof Generation
Aug 24, 2022
Manav-Aggarwal
force-pushed
the
manav/abci_add_generate
branch
from
August 24, 2022 03:06
eacacf0
to
34815ec
Compare
Codecov Report
@@ Coverage Diff @@
## abci_fraud_proofs #43 +/- ##
====================================================
Coverage ? 45.86%
====================================================
Files ? 279
Lines ? 51244
Branches ? 0
====================================================
Hits ? 23504
Misses ? 25873
Partials ? 1867 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tzdybal
reviewed
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address linter issues (split long lines). Other than that, LGTM.
Co-authored-by: Tomasz Zdybał <tomek@zdybal.lap.pl>
tzdybal
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following methods required for fraudproof generation to the ABCI interface:
GetAppHash () -> appHash
TriggerFraudProofGenerationMode () -> ModeEnabledSuccess
GenerateFraudProof () -> FraudProof
Fraud Proof type described in celestiaorg/cosmos-sdk#248
Closes: #4