fix(node-resolve): handle browser-mapped paths correctly in nested co…

…ntexts (#920)
rollup · Jul 24, 2021 · 1e2363c · 1e2363c
1 parent 4bd1beb
commit 1e2363c
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 2 deletions.
diff --git a/packages/node-resolve/src/index.js b/packages/node-resolve/src/index.js
@@ -88,7 +88,7 @@ export function nodeResolve(opts = {}) {
         return { id: ES6_BROWSER_EMPTY };
       }
       const browserImportee =
-        browser[importee] ||
+        (importee[0] !== '.' && browser[importee]) ||
         browser[resolvedImportee] ||
         browser[`${resolvedImportee}.js`] ||
         browser[`${resolvedImportee}.json`];

diff --git a/packages/node-resolve/test/browser.js b/packages/node-resolve/test/browser.js
@@ -146,7 +146,7 @@ test('allows use of object browser field, resolving nested directories', async (
   t.is(module.exports.test, 43);
 });
 
-test('respects local browser field', async (t) => {
+test('respects local browser field for external dependencies', async (t) => {
   const bundle = await rollup({
     input: 'browser-local.js',
     onwarn: () => t.fail('No warnings were expected'),
@@ -161,6 +161,39 @@ test('respects local browser field', async (t) => {
   t.is(module.exports, 'component-type');
 });
 
+test('respects local browser field for internal dependencies', async (t) => {
+  const bundle = await rollup({
+    input: 'browser-local-relative.js',
+    onwarn: () => t.fail('No warnings were expected'),
+    plugins: [
+      nodeResolve({
+        mainFields: ['browser', 'main']
+      })
+    ]
+  });
+  const { module } = await testBundle(t, bundle);
+
+  t.is(module.exports, 'component-type');
+});
+
+test('does not apply local browser field for matching imports in nested paths', async (t) => {
+  try {
+    await rollup({
+      input: 'nested/browser-local-relative.js',
+      onwarn: () => t.fail('No warnings were expected'),
+      plugins: [
+        nodeResolve({
+          mainFields: ['browser', 'main']
+        })
+      ]
+    });
+  } catch (e) {
+    t.is(e.code, 'UNRESOLVED_IMPORT');
+    return;
+  }
+  t.fail('expecting error');
+});
+
 test('allows use of object browser field, resolving to nested node_modules', async (t) => {
   const bundle = await rollup({
     input: 'browser-entry-points-to-node-module.js',

diff --git a/packages/node-resolve/test/fixtures/browser-local-relative.js b/packages/node-resolve/test/fixtures/browser-local-relative.js
@@ -0,0 +1,4 @@
+// test browser mapped imports from the main entrypoint
+import s from './dummy-relative';
+
+export default s;
diff --git a/packages/node-resolve/test/fixtures/nested/browser-local-relative.js b/packages/node-resolve/test/fixtures/nested/browser-local-relative.js
@@ -0,0 +1,4 @@
+// test browser mapped imports from the main entrypoint
+import s from './dummy-relative';
+
+export default s;
diff --git a/packages/node-resolve/test/fixtures/package.json b/packages/node-resolve/test/fixtures/package.json
@@ -8,6 +8,7 @@
   "scripts": {},
   "keywords": [],
   "browser": {
+    "./dummy-relative": "component-type",
     "dummy-module": "component-type"
   }
 }