fix(typescript): allow for files to be nested in folders within outDir #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change corrects a regression introduced by rollup#1728, preventing dual bundle configs from writing output files to directories nested within the directory defined in the tsconfig's outDir property. Example: ```js export default { input: 'src/index.ts', // Replace with the path to your entry TypeScript file output: [ { dir: 'dist/cjs', format: 'cjs', sourcemap: true, preserveModules: true }, { dir: 'dist/esm', format: 'esm', sourcemap: true, preserveModules: true } ], plugins: [ json(), resolve(), commonjs(), typescript({ tsconfig: 'tsconfig.json', compilerOptions: { /* Basic Options */ target: 'ES5', module: 'ES2020', lib: ['ES2019', 'ES2020'], allowJs: true, checkJs: false, /* Strict Type-Checking Options */ strict: true, /* Module Resolution Options */ moduleResolution: 'node', esModuleInterop: true, /* Advanced Options */ forceConsistentCasingInFileNames: true, skipDefaultLibCheck: true, skipLibCheck: true, outDir: path.join(__dirname, 'dist') } }) ], external: deps // Add any external dependencies you don't want to bundle }; ```
|
Appreciate you stepping up on this one. |
remarkablemark
added a commit
to remarkablemark/npm-package-typescript-template
that referenced
this pull request
Nov 10, 2024
mergify bot
pushed a commit
to remarkablemark/npm-package-typescript-template
that referenced
this pull request
Nov 10, 2024
…#641) * build(deps-dev): bump @rollup/plugin-typescript from 11.1.6 to 12.1.1 Bumps [@rollup/plugin-typescript](https://github.com/rollup/plugins/tree/HEAD/packages/typescript) from 11.1.6 to 12.1.1. - [Changelog](https://github.com/rollup/plugins/blob/master/packages/typescript/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/typescript-v12.1.1/packages/typescript) --- updated-dependencies: - dependency-name: "@rollup/plugin-typescript" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * build(rollup): allow for files to be nested in folders within outDir See rollup/plugins#1783 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark <mark@remarkablemark.org>
remarkablemark
added a commit
to remarkablemark/html-react-parser
that referenced
this pull request
Nov 10, 2024
See rollup/plugins#1783 ``` @rollup/plugin-typescript 11.1.6 → 12.1.1 rollup 4.24.4 → 4.25.0 ```
remarkablemark
added a commit
to remarkablemark/html-react-parser
that referenced
this pull request
Nov 10, 2024
See rollup/plugins#1783 ``` @rollup/plugin-typescript 11.1.6 → 12.1.1 rollup 4.24.4 → 4.25.0 ```
4 tasks
remarkablemark
added a commit
to remarkablemark/html-react-parser
that referenced
this pull request
Nov 10, 2024
See rollup/plugins#1783 ``` @rollup/plugin-typescript 11.1.6 → 12.1.1 rollup 4.24.4 → 4.25.0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
typescriptThis PR contains:
Are tests included?
Breaking Changes?
Description
This change corrects a regression introduced by #1728, preventing dual bundle configs from writing output files to directories nested within the directory defined in the tsconfig's outDir property.
Example:
Fixes #1773