-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multi-entry): add typescript typings #198
Closed
LukasBombach
wants to merge
2
commits into
rollup:master
from
LukasBombach:type-declarations-for-multi
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// @ts-check | ||
import multiEntry from ".."; | ||
|
||
/** @type {import("rollup").RollupOptions} */ | ||
const config = { | ||
input: ["main.js", "secondary.js"], | ||
output: { | ||
file: "bundle.js", | ||
format: "iife", | ||
name: "MyModule" | ||
}, | ||
plugins: [ | ||
multiEntry({ | ||
exports: false | ||
}) | ||
] | ||
}; | ||
|
||
export default config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { Plugin } from "rollup"; | ||
|
||
export interface Options { | ||
/** | ||
* If `true`, instructs the plugin to export named exports to the bundle from all | ||
* entries. If `false`, the plugin will not export any entry exports to the bundle. | ||
* This can be useful when wanting to combine code from multiple entry files, but | ||
* not necessarily to export each entry file's exports. | ||
* @default true | ||
*/ | ||
exports?: boolean; | ||
} | ||
|
||
/** | ||
* 🍣 A Rollup plugin which allows use of multiple entry points for a bundle. | ||
*/ | ||
export default function multiEntry(options?: Options): Plugin; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The options type can also be the
input
type: string, string array, or object with includes/excludes. See the configure functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, that contradicts the readme, that should be updated too then
https://github.com/rollup/plugins/tree/master/packages/multi-entry#options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shellscape Is this intended behaviour? If so I agree we should update the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README isn't necessarily wrong, but it needs an update to be more in line with other plugins. Specifically around
include
andexclude