feat(html): support custom meta element creation

[mseeley]

This allows for convenient creation of meta elements without reimplementing all template function responsibilities.

Rollup Plugin Name: html

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: n/a

Description

The html plugin doesn't allow for injection of meta elements without re-implementing all of the template function responsibilities. This is bunch of relative complexity to take on in order to, in my case, inject our old friendly viewport meta below:

<meta
  name="viewport"
  content="minimum-scale=1, initial-scale=1, width=device-width"
/>

Instead I added support for a backwards compatible meta option.

• when omitted the current utf-8 charset meta will be inserted.
• when provided the charset meta must be supplied manually. To me this was the simplest implementation and an easy to doc/grok all or nothing approach.

Running tests locally some snapshots are failing with null vs undefined values for map. I'm running 12.15.0 using nvm. Perhaps there's a behavior changes between 12 and 12.xx. Tests passed for changed code, so, here we go. 🎉

[mseeley]

Pre-review complete. Nothing mysterious here. :)

[mseeley]

I'm happy to copy/paste any documentation suggestions.

[mseeley]

Resolved snapshot updating. The addition of map: undefined and map: null are still unknown.

Ah, I'm seeing CI fail with similar problems I had locally. ~I don't believe my changes are causing those failures.~ The `map` failures don't seem related. But, the snapshot failure is.

Running: pnpm run test --filter ./packages/html from the root doesn't give me the chance to update snapshots: https://gist.github.com/mseeley/44b1488096802aef9cff9dc4e974d4c2. Also, notice the map problems.

Installing AVA locally then running tests in the package does nothing when entering u to update the specs.

Thanks for any help sorting out what the heck is going on.

[shellscape]

Thanks for opening this PR. We'll get to reviewing this soon!

[mseeley]

@shellscape thanks for updating the html snapshots in c09509f. Diff on this PR is now super tight. 😄

[mseeley]

👋 hi maintainers. Please let me know if there's anything I can do to raise visibility of this PR. I'm hoping you all find it to be a reasonable feature addition. Thanks!

[shellscape]

[shellscape]

@mseeley If you're interested in helping to maintain the repo in the future, please let me know. We're always looking for help.