Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

fix-bug: Could not load G:\luobata\canvas-input-methods\src\ui/index (imported..... #30

Closed
wants to merge 1 commit into from

Conversation

Luobata
Copy link

@Luobata Luobata commented Aug 22, 2017

I find it will throw out an exception when I import a module with alias like 'import init from 'UI/index.js' in window. It's same as the issue #11 .

And I find it it's the bug with the updatedId in windows in started with 'G:' so it can't be match by the regex /^.?//, so I change the regex and format the updatedId(.split(path.sep).join('/')) to promise it would be matched by the regex.

I also find it that the dist file in the node_modules in version 1.3.1, it has posix.resolve, and path.resolve in source code.And I had tested that it work with path.resolve after my PR.

Signed-off-by: Luobata 602975805@qq.com

…e match by the regex;

Signed-off-by: Luobata <602975805@qq.com>
@mhhegazy
Copy link
Contributor

mhhegazy commented Sep 17, 2017

@Luobata
posix.resolve doesn't work with updatedId as you expect in your scenario
and this regex misses many cases

@Rich-Harris
Copy link
Contributor

Thanks for the PR — Released 1.4.0 which fixes #11 via #22, so I think we can probably close this. Let us know if that's not the case

@shellscape shellscape closed this Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants