This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Better handling of helpers #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and it changes |
| @@ -46,7 +44,7 @@ describe( 'rollup-plugin-babel', function () { | |||
| }); | |||
| }); | |||
|
|
|||
| it( 'adds helpers', function () { | |||
| it.only( 'adds helpers', function () { | |||
There was a problem hiding this comment.
good catch! fixed
|
Looking good! Lots of improvements going down lately! 😉 |
Victorystick
added a commit
that referenced
this pull request
Dec 29, 2015
Better handling of helpers
|
👍 Haven't tried it, but seems good. |
@Rich-Harris something is going wrong with this change I'm seeing the following for the function babelHelpers_createClass () {
function defineProperties(target, props) {
for (var i = 0; i < props.length; i++) {
var descriptor = props[i];
descriptor.enumerable = descriptor.enumerable || false;
descriptor.configurable = true;
if ("value" in descriptor) descriptor.writable = true;
Object.defineProperty(target, descriptor.key, descriptor);
}
}
return function (Constructor, protoProps, staticProps) {
if (protoProps) defineProperties(Constructor.prototype, protoProps);
if (staticProps) defineProperties(Constructor, staticProps);
return Constructor;
};
}();This change is also making the function declarations end with a function babelHelpers_classCallCheck (instance, Constructor) {
if (!(instance instanceof Constructor)) {
throw new TypeError("Cannot call a class as a function");
}
};I think you should rename them to |
ericf
added a commit
to ericf/rollup-plugin-babel
that referenced
this pull request
Jan 7, 2016
The renaming from `babelHelpers.foo =` to a function declaration `function babelHelpers_foo()` was incorrect as the helpers are defined as expressions. This puts back the helper functions being defined as function expressions but keeps the better-minifiable `babelHelpers_` bindings. See: rollup#19 (comment)
|
PR to fix the above: #31 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #17 by allowing runtime helpers if applicable via a
runtimeHelpers: trueoption. It's also a bit more permissive about helpers generally – it will only complain about the lack ofexternal-helpers-2if helpers are in fact duplicated, and it will warn instead of throwing an error.It also points to some better documentation explaining why these are needed.
@Victorystick @eventualbuddha does this seem like the right direction?