Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use acorn-class-fields and acorn-static-class-features from npm #3518

Merged
merged 1 commit into from
Apr 27, 2020
Merged

use acorn-class-fields and acorn-static-class-features from npm #3518

merged 1 commit into from
Apr 27, 2020

Conversation

nitsky
Copy link
Contributor

@nitsky nitsky commented Apr 27, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #3478 #3501

Description

acorn-class-fields and acorn-static-class-features have been updated to support acorn 7. This PR references them from npm as opposed to the forks from @guybedford. The latest version of acorn-class-fields also includes a fix that closes #3501.

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #3518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3518   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         176      176           
  Lines        5984     5984           
  Branches     1762     1762           
=======================================
  Hits         5752     5752           
  Misses        118      118           
  Partials      114      114           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e6fa8...596bbea. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert merged commit 21705fa into rollup:master Apr 27, 2020
@lgersman
Copy link

lgersman commented May 12, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support node --disable-proto
3 participants