fix: find whitespace from operator position to start

[TrickyPi]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:
resolves #5583

Description

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 21, 2024 4:38pm

[github-actions]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-5583

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-5kj4kflxf-rollup-js.vercel.app/repl/?pr=5584

[github-actions]

Performance report!

Rough benchmark

Command	Mean [s]	Min [s]	Max [s]	Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js	9.177 ± 0.025	9.161	9.206	1.00 ± 0.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js	9.171 ± 0.021	9.152	9.194	1.00

Internal benchmark

• BUILD: 8112ms, 748 MB
  • initialize: 0ms, 25.9 MB
  • generate module graph: 3128ms, 574 MB
    • generate ast: 1530ms, 567 MB
  • sort and bind modules: 451ms, 621 MB
  • mark included statements: 4536ms, 748 MB
    • treeshaking pass 1: 1534ms, 715 MB
    • treeshaking pass 2: 737ms, 744 MB
    • treeshaking pass 3: 290ms, 745 MB
    • treeshaking pass 4: 269ms, 744 MB
    • treeshaking pass 5: 314ms, 747 MB
    • treeshaking pass 6: 257ms, 755 MB
    • treeshaking pass 7: 242ms, 753 MB
    • treeshaking pass 8: 235ms, 758 MB
    • treeshaking pass 9: 214ms, 755 MB
    • treeshaking pass 10: 217ms, 752 MB
    • treeshaking pass 11: 213ms, 748 MB
• GENERATE: 882ms, 1.02 GB
  • initialize render: 0ms, 914 MB
  • generate chunks: 87ms, 917 MB
    • optimize chunks: 0ms, 918 MB
  • render chunks: 774ms, 1 GB
  • transform chunks: 21ms, 1.02 GB
  • generate bundle: 0ms, 1.02 GB

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (28546b5) to head (348dd91).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5584   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         241      241           
  Lines        9273     9280    +7     
  Branches     2444     2446    +2     
=======================================
+ Hits         9185     9192    +7     
  Misses         58       58           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lukastaegert]

Thanks so much for the fix! This makes me wonder if we should not consider including ParenthesizedExpression nodes at some point, even if they are non-standard. But maybe they would cause more problems in other areas...

[github-actions]

This PR has been released as part of rollup@4.19.1. You can test it via npm install rollup.

[TrickyPi]

The SWC AST include ParenthesisExpression node. If we want to include ParenthesisExpression in the Rollup AST, we need to compatibilize the ESTree AST nodes from third-party plugins.