Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include shaders from ShaderLib/ directory too #7

Closed
wants to merge 1 commit into from

Conversation

arose
Copy link

@arose arose commented Jun 23, 2016

No description provided.

@Rich-Harris
Copy link
Contributor

Thanks, just seen this! I was working this over the weekend and ended up doing basically the same thing – sorry for not using your PR instead :(

FYI it's now a PR on Three.js itself – mrdoob/three.js#9310

@arose
Copy link
Author

arose commented Jul 11, 2016

Sure, no problem. Thanks for making rollup and for making it lightweight, it has been the reason why I switched to es6 modules in NGL and I really don't want to look back.

I really hope the PR on three.js will be accepted eventually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants