Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from aioredis to hiredis, update to pydantic v2 #3

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

pabdavis
Copy link
Contributor

Hello, I wanted to use this within a project, so I updated a few of the packages.

@roma-glushko roma-glushko self-requested a review May 31, 2024 08:22
Copy link
Owner

@roma-glushko roma-glushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, Bill 👍

@roma-glushko roma-glushko added the enhancement New feature or request label May 31, 2024
@roma-glushko
Copy link
Owner

Will take a look at the tests to fix the failures. They don't seem to be connected to the PR.

@pabdavis
Copy link
Contributor Author

pabdavis commented Jun 3, 2024

Attempted to update the test github action (not tested thou)

@roma-glushko
Copy link
Owner

Perfect Bill 👍 Merging the PR and will make sure this change is published as a new PyPi version.

@roma-glushko roma-glushko merged commit f4aa606 into roma-glushko:main Jun 9, 2024
4 checks passed
@roma-glushko
Copy link
Owner

The new version of the emitter has just published under v0.0.3 🎉
https://pypi.org/project/socket.io-redis-emitter/0.0.3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants