Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: p2p configuration seems to be messed up #440

Closed
Kixunil opened this issue Jul 22, 2021 · 3 comments
Closed

Bug: p2p configuration seems to be messed up #440

Kixunil opened this issue Jul 22, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Kixunil
Copy link
Contributor

Kixunil commented Jul 22, 2021

Describe the bug
auth doesn't seem to be used in p2p branch, only cookie_file.
Moreover the original plan was to turn use of cookie into hard error with a nice message before removing it entirely.
Do we still want to do that? I think it'd be nicer for at least one release.

To Reproduce
Steps to reproduce the behavior:

  1. git checkout p2p
  2. vim src/config.rs
  3. /auth
  4. "Pattern not found: auth"

Expected behavior
auth is used instead of cookie if specified (error if both are specified).

Additional context
Was just thinking about turning it into hard error in 0.9 - looks like we're thinking the same here.

@Kixunil Kixunil added the bug Something isn't working label Jul 22, 2021
@romanz
Copy link
Owner

romanz commented Jul 22, 2021

Oops, good catch - thanks!
Will fix.

@romanz
Copy link
Owner

romanz commented Jul 22, 2021

Should be fixed in #442, please take a look :)

@romanz romanz closed this as completed Jul 22, 2021
@romanz romanz reopened this Jul 24, 2021
@romanz
Copy link
Owner

romanz commented Jul 24, 2021

Log verbosity is not propagated correctly: #446 (comment)

@romanz romanz self-assigned this Jul 24, 2021
romanz added a commit that referenced this issue Jul 27, 2021
@romanz romanz closed this as completed Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants